Pockets or no pockets?
Pockets can be a great addition to a shirt; it can also be a huge deterrent.
Generally speaking, if the dressier a shirt, the less likely it will have a pocket. Pockets are a great option for casual oxfords, flannels or plaids. They often add some dimension and character to a casual shirt, and most importantly functionality!
Pockets on a formal shirt are a bit passé. We would never recommend a pocket on a French cuff shirt, or with a widespread collar.